Feat/giveaway blacklist #137
Open
+193
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hilmoo
commented
Jul 21, 2024
•
hilmoo
commented
- testing
|
this pull req extend #136 |
|
nvm, i forgot carl bot can handle that |
|
waiting for #136 to merge for testing |
Iqrar99
requested changes
Sep 21, 2024
bot/cogs/giveaway.py
Outdated
Comment on lines
28
to
29
| winner='Winner of the giveaway. Example: 1234567890,0987654321', | ||
| ghosting='Member who do not claim the giveaway. Example: 1234567890,0987654321', |
There was a problem hiding this comment.
The example is too long for a parameter description
There was a problem hiding this comment.
I don't think it's too long, it helps users understand how to separate them if more than one is entered
|
The code still has a syntax error. I’ll check it later, but for now, I can't test it on Discord. |
|
already tested the feature. lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.